Skip to content

Conversation

myankelev
Copy link
Member

@myankelev myankelev commented Sep 9, 2025

Tests changed:

  • test/jdk/sun/security/pkcs11/Config/ReadConfInUTF16Env.java
  • test/jdk/sun/security/pkcs11/PKCS11Test.java
  • test/jdk/sun/security/pkcs11/Secmod/AddPrivateKey.java
  • test/jdk/sun/security/pkcs11/Secmod/AddTrustedCert.java
  • test/jdk/sun/security/pkcs11/Secmod/Crypto.java
  • test/jdk/sun/security/pkcs11/Secmod/GetPrivateKey.java
  • test/jdk/sun/security/pkcs11/Secmod/JksSetPrivateKey.java
  • test/jdk/sun/security/pkcs11/Secmod/LoadKeystore.java
  • test/jdk/sun/security/pkcs11/Secmod/TestNssDbSqlite.java
  • test/jdk/sun/security/pkcs11/Secmod/TrustAnchors.java
  • test/jdk/sun/security/pkcs11/SecmodTest.java
  • test/jdk/sun/security/pkcs11/ec/ReadCertificates.java
  • test/jdk/sun/security/pkcs11/ec/ReadPKCS12.java
  • test/jdk/sun/security/pkcs11/ec/TestKeyFactory.java
  • test/jdk/sun/security/pkcs11/rsa/KeyWrap.java
  • test/jdk/sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8367096: jdk/open/test/jdk/sun/security/pkcs11/ rsa, ec, config, secmod and sslecc tests are skipping but showing as pass (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27166/head:pull/27166
$ git checkout pull/27166

Update a local copy of the PR:
$ git checkout pull/27166
$ git pull https://git.openjdk.org/jdk.git pull/27166/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27166

View PR using the GUI difftool:
$ git pr show -t 27166

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27166.diff

Using Webrev

Link to Webrev Comment

…test/jdk/sun/security/pkcs11/ec tests are skipping but showing as pass
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 9, 2025

👋 Welcome back myankelevich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 9, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title JDK-8367096: jdk/open/test/jdk/sun/security/pkcs11/ rsa, ec, config, secmod and sslecc tests are skipping but showing as pass 8367096: jdk/open/test/jdk/sun/security/pkcs11/ rsa, ec, config, secmod and sslecc tests are skipping but showing as pass Sep 9, 2025
@openjdk
Copy link

openjdk bot commented Sep 9, 2025

@myankelev The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security [email protected] rfr Pull request is ready for review labels Sep 9, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 9, 2025

Webrevs

Copy link
Contributor

@mpdonova mpdonova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just some minor suggestions on the exception messages. Don't feel like you have to change them if you like them as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review security [email protected]
Development

Successfully merging this pull request may close these issues.

2 participants