8367268: Remove unused os::numa_topology_changed()

[jsikstro]

Hello,

The method os::numa_topology_changed() returns false on all platforms with no callers. It makes sense to remove it as the JVM does not support changing the NUMA topology during runtime, or in other words, hotswapping CPUs. There are a lot of places that break if the NUMA topology would change during runtime.

The last implementation of os::numa_topology_changed() that did something other than just returning false was removed in JDK-8244224 with the removal of the Solaris and SPARC ports.

I do not see an issue with building on AIX, but would appreciate any feedback on this from AIX maintainers.

Testing:

• tier1 on Oracle supported platforms

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8367268: Remove unused os::numa_topology_changed() (Enhancement - P4)

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27176/head:pull/27176
$ git checkout pull/27176

Update a local copy of the PR:
$ git checkout pull/27176
$ git pull https://git.openjdk.org/jdk.git pull/27176/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27176

View PR using the GUI difftool:
$ git pr show -t 27176

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27176.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jsikstro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jsikstro This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8367268: Remove unused os::numa_topology_changed()

Reviewed-by: ayang, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@jsikstro The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (0afe7aa4)
• 00: Full (7205d735)

[dholmes-ora]

Nice cleanup. Thanks

[jsikstro]

Thank you for the reviews @albertnetymk and @dholmes-ora!
/integrate

[openjdk]

Going to push as commit 3d67908.

[openjdk]

@jsikstro Pushed as commit 3d67908.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.