Skip to content

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Sep 10, 2025

Test tests navigation on virtual file created on Virtual File System which is not supported in macos so restricting it for osx run.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Warning

 ⚠️ Found trailing period in issue title for 8024419: Can not find the specified directory in the frame.

Issue

  • JDK-8024419: Can not find the specified directory in the frame. (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27185/head:pull/27185
$ git checkout pull/27185

Update a local copy of the PR:
$ git checkout pull/27185
$ git pull https://git.openjdk.org/jdk.git pull/27185/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27185

View PR using the GUI difftool:
$ git pr show -t 27185

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27185.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 10, 2025

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 10, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Sep 10, 2025

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added client [email protected] rfr Pull request is ready for review labels Sep 10, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 10, 2025

Webrevs

@@ -29,6 +29,7 @@
/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: copyright year

@@ -29,6 +29,7 @@
/*
* @test
* @bug 6698013
* @requires (os.family != "mac")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think explaining the reason behind the blocking of the macOS in @summary would be helpful?

Copy link
Contributor

@honkar-jdk honkar-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from minor test instruction update for clarity.

This test verifies navigating into subdir two ways:

1. Verify if you are able to go into subdir by double click and then return to "testdir" parent directory.
2. Next select 'subdir' folder and press the 'Open' button

If both methods of navigating into the subdir work, press Pass else Fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants