-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8024419: Can not find the specified directory in the frame. #27185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@@ -29,6 +29,7 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: copyright year
@@ -29,6 +29,7 @@ | |||
/* | |||
* @test | |||
* @bug 6698013 | |||
* @requires (os.family != "mac") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think explaining the reason behind the blocking of the macOS in @summary
would be helpful?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from minor test instruction update for clarity.
This test verifies navigating into subdir two ways:
1. Verify if you are able to go into subdir by double click and then return to "testdir" parent directory.
2. Next select 'subdir' folder and press the 'Open' button
If both methods of navigating into the subdir work, press Pass else Fail.
Test tests navigation on virtual file created on Virtual File System which is not supported in macos so restricting it for osx run.
Progress
Warning
8024419: Can not find the specified directory in the frame.
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27185/head:pull/27185
$ git checkout pull/27185
Update a local copy of the PR:
$ git checkout pull/27185
$ git pull https://git.openjdk.org/jdk.git pull/27185/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27185
View PR using the GUI difftool:
$ git pr show -t 27185
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27185.diff
Using Webrev
Link to Webrev Comment