8367902: Allocation after Universe::before_exit() in the VM shutdown sequence

[lmesnik]

Please review following fix that move GC shutdown start after VM Death and agent's unloading.

The Universe::before_exit(); switch GC to fail any new GC allocation. So any allocation in vm death is failing.

The test is a little bit complicated because jtreg uses wrapper even to execute othrevm tests and also results might be confusing if test is failing after main() method is completed. So the better is to run new process for vm death event handling.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8367902: Allocation after Universe::before_exit() in the VM shutdown sequence (Bug - P2)

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Stefan Karlsson (@stefank - Reviewer)
• Ivan Walulya (@walulyai - Reviewer)
• Axel Boldt-Christmas (@xmas92 - Reviewer)
• Serguei Spitsyn (@sspitsyn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28227/head:pull/28227
$ git checkout pull/28227

Update a local copy of the PR:
$ git checkout pull/28227
$ git pull https://git.openjdk.org/jdk.git pull/28227/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28227

View PR using the GUI difftool:
$ git pr show -t 28227

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28227.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8367902: Allocation after Universe::before_exit() in the VM shutdown sequence

Reviewed-by: ayang, stefank, iwalulya, aboldtch, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 47 new commits pushed to the master branch:

• 78db38f: 8371365: Update javax/swing/JFileChooser/bug4759934.java to use Util.findComponent()
• e5c7293: 8371645: BasicImageReader getEntryNames() is stateful and cannot be called more than once
• 56a27d1: 8341039: compiler/cha/TypeProfileFinalMethod.java fails with assertEquals expected: 0 but was: 2
• ... and 44 more: https://git.openjdk.org/jdk/compare/88c4678eed818cbe9380f35352e90883fed27d33...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@lmesnik The following labels will be automatically applied to this pull request:

• hotspot-runtime
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[lmesnik]

/cc hotspot-gc

[openjdk]

@lmesnik
The hotspot-gc label was successfully added.

[mlbridge]

Webrevs

• 03: Full - Incremental (6d367b4a)
• 02: Full - Incremental (be6eb483)
• 01: Full - Incremental (e728034d)
• 00: Full (a49d67ca)

[albertnetymk]

move GC shutdown start after VM Death and agent's unloading

Is there a reason why Universe::before_exit() is moved down, instead of moving jvmti related calls (before Universe::before_exit())?

(The current patch would leave GC running while calling MemMapPrinter::print_all_mappings(tty); -- GC can potentially alter mappings.)

[stefank]

I agree with Albert. I would prefer a patch that moves the JVMTI code instead. This is also what I've tested through tier1-8 in my queue of patches to clean up some of the shutdown code:
https://github.com/stefank/jdk/tree/remove_2s_shutdown_workaround

[openjdk]

@lmesnik build has been added to this pull request based on files touched in new commit(s).

[lmesnik]

@albertnetymk, @stefank

move GC shutdown start after VM Death and agent's unloading

Is there a reason why Universe::before_exit() is moved down, instead of moving jvmti related calls (before Universe::before_exit())?

I updated to move jvmti code. Seems that following opertaions
WatcherThread::stop();
NativeHeapTrimmer::cleanup();
might be done before sending jvmti vm_death.

[stefank]

Looks good and thanks for the test!

[xmas92]

lgtm.

[sspitsyn]

Looks good. Thank you for fixing this issue!

[lmesnik]

/integrate

[openjdk]

Going to push as commit 705bd6f.
Since your change was applied there have been 47 commits pushed to the master branch:

• 78db38f: 8371365: Update javax/swing/JFileChooser/bug4759934.java to use Util.findComponent()
• e5c7293: 8371645: BasicImageReader getEntryNames() is stateful and cannot be called more than once
• 56a27d1: 8341039: compiler/cha/TypeProfileFinalMethod.java fails with assertEquals expected: 0 but was: 2
• ... and 44 more: https://git.openjdk.org/jdk/compare/88c4678eed818cbe9380f35352e90883fed27d33...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lmesnik Pushed as commit 705bd6f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.