-
Notifications
You must be signed in to change notification settings - Fork 251
8337506: Disable "best-fit" mapping on Windows command line #3062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
@kvergizova This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/keepalive |
|
@kvergizova The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
@kvergizova This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/keepalive |
|
@kvergizova The pull request is being re-evaluated and the inactivity timeout has been reset. |
I'd like to backport this for parity with 11.0.29-oracle.
CSR JDK-8349538 has been approved for 11u.
17u patch applies cleanly, but the test requires a few modifications to work properly:
native.encodingproperty withfile.encoding, asnative.encodingis not present in 11u.These two are identical unless
file.encodingis overridden on the command line:https://github.com/openjdk/jdk17u-dev/blob/master/src/java.base/share/classes/jdk/internal/util/SystemProps.java#L72
"str".formatted(args)withString.format("str", args), as String::formatted() is not available in 11u. Both methods produce the same result.The new test passes successfully after applying the patch.
Progress
Issues
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3062/head:pull/3062$ git checkout pull/3062Update a local copy of the PR:
$ git checkout pull/3062$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3062/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3062View PR using the GUI difftool:
$ git pr show -t 3062Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3062.diff
Using Webrev
Link to Webrev Comment