-
Notifications
You must be signed in to change notification settings - Fork 232
8350102: Decouple jpackage test-lib Executor.Result and Executor classes #4033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
|
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
4ff135a to
f6f2b7a
Compare
|
@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
|
/integrate |
|
Going to push as commit 571408e.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 17.0.18-oracle.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4033/head:pull/4033$ git checkout pull/4033Update a local copy of the PR:
$ git checkout pull/4033$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4033/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4033View PR using the GUI difftool:
$ git pr show -t 4033Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4033.diff
Using Webrev
Link to Webrev Comment