Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 10, 2025

I backport this for parity with 17.0.18-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8350102 needs maintainer approval

Issue

  • JDK-8350102: Decouple jpackage test-lib Executor.Result and Executor classes (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4033/head:pull/4033
$ git checkout pull/4033

Update a local copy of the PR:
$ git checkout pull/4033
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4033/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4033

View PR using the GUI difftool:
$ git pr show -t 4033

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4033.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 10, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 10, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350102: Decouple jpackage test-lib Executor.Result and Executor classes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • d167b4d: 8354465: Open some JTable bugs 8
  • b802991: 8354341: Open some JTable bugs 7
  • be5ae4c: 8363676: [GCC static analyzer] missing return value check of malloc in OGLContext_SetTransform

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title backport 3487f8cbd55b06d332d897a010ae8eb371dd4956 8350102: Decouple jpackage test-lib Executor.Result and Executor classes Oct 10, 2025
@openjdk
Copy link

openjdk bot commented Oct 10, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 10, 2025
@openjdk
Copy link

openjdk bot commented Oct 10, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 10, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 10, 2025

Webrevs

@openjdk openjdk bot removed the clean Identical backport; no merge resolution required label Oct 14, 2025
@GoeLin GoeLin force-pushed the goetz_backport_8350102 branch from 4ff135a to f6f2b7a Compare October 29, 2025 11:55
@openjdk
Copy link

openjdk bot commented Oct 29, 2025

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added clean Identical backport; no merge resolution required approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 29, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Oct 30, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Oct 30, 2025

Going to push as commit 571408e.
Since your change was applied there have been 3 commits pushed to the master branch:

  • d167b4d: 8354465: Open some JTable bugs 8
  • b802991: 8354341: Open some JTable bugs 7
  • be5ae4c: 8363676: [GCC static analyzer] missing return value check of malloc in OGLContext_SetTransform

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 30, 2025
@openjdk openjdk bot closed this Oct 30, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 30, 2025
@openjdk
Copy link

openjdk bot commented Oct 30, 2025

@GoeLin Pushed as commit 571408e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8350102 branch October 30, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant