Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 26, 2025

I backport this for parity with 17.0.18-oracle.

Clean backport, but need to adapt as HttpClient does not implement
AutoClosable in 17.
Omitted calls to close, test is run as othervm.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8314136 needs maintainer approval

Issue

  • JDK-8314136: Test java/net/httpclient/CancelRequestTest.java failed: WARNING: tracker for HttpClientImpl(42) has outstanding operations (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4109/head:pull/4109
$ git checkout pull/4109

Update a local copy of the PR:
$ git checkout pull/4109
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4109/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4109

View PR using the GUI difftool:
$ git pr show -t 4109

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4109.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 26, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 26, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314136: Test java/net/httpclient/CancelRequestTest.java failed: WARNING: tracker for HttpClientImpl(42) has outstanding operations

Reviewed-by: rschmelter

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • d167b4d: 8354465: Open some JTable bugs 8
  • b802991: 8354341: Open some JTable bugs 7
  • be5ae4c: 8363676: [GCC static analyzer] missing return value check of malloc in OGLContext_SetTransform

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title backport 4f864faf428c8171be975a79db5bc2bc145f8805 8314136: Test java/net/httpclient/CancelRequestTest.java failed: WARNING: tracker for HttpClientImpl(42) has outstanding operations Oct 26, 2025
@openjdk
Copy link

openjdk bot commented Oct 26, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Oct 26, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 26, 2025

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Oct 27, 2025

GHA failure: test java/lang/ProcessBuilder/Basic#id0 failed. Unrelated.

@GoeLin GoeLin changed the base branch from master to pr/4101 October 27, 2025 18:33
@GoeLin
Copy link
Member Author

GoeLin commented Oct 27, 2025

GHA failure: java/lang/ProcessBuilder/Basic#id0 failed. Unrelated.
Might be fixed by #4097

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/4101 to master October 28, 2025 09:30
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout goetz_backport_8314136
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

Copy link
Contributor

@schmelter-sap schmelter-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Oct 29, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants