8369946: Bytecode rewriting causes Java heap corruption on PPC

[TheRealMDoerr]

Backport of JDK-8369946 from jdk21u-dev.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8369946 needs maintainer approval

Issue

• JDK-8369946: Bytecode rewriting causes Java heap corruption on PPC (Bug - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4114/head:pull/4114
$ git checkout pull/4114

Update a local copy of the PR:
$ git checkout pull/4114
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4114/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4114

View PR using the GUI difftool:
$ git pr show -t 4114

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4114.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8369946: Bytecode rewriting causes Java heap corruption on PPC

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• d167b4d: 8354465: Open some JTable bugs 8
• b802991: 8354341: Open some JTable bugs 7
• be5ae4c: 8363676: [GCC static analyzer] missing return value check of malloc in OGLContext_SetTransform
• ... and 14 more: https://git.openjdk.org/jdk17u-dev/compare/f4c80e318a4a72f5308310d352e5504414716fa4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (0a98de83)

[TheRealMDoerr]

GHA test failure is obviously unrelated.

[GoeLin]

GHA test failure is obviously unrelated.

Yes, I hope it will be fixed by #4097
I saw it a few times the past days.

[TheRealMDoerr]

/approval request JDK17u is also affected. The fix is very new, but adding memory barriers doesn't break anything and the interpreter performance impact is not very high. The fix can potentially prevent some extremely rare crashes or failures. Backport from jdk21u-dev is clean and all our tests have passed.

[openjdk]

@TheRealMDoerr
8369946: The approval request has been created successfully.

[TheRealMDoerr]

/integrate

[openjdk]

Going to push as commit e78cfbe.
Since your change was applied there have been 23 commits pushed to the master branch:

• 74b7d69: 8314136: Test java/net/httpclient/CancelRequestTest.java failed: WARNING: tracker for HttpClientImpl(42) has outstanding operations
• 133dad6: 8333526: Restructure java/nio/channels/DatagramChannel/StressNativeSignal.java to a fail fast exception handling policy
• 458a4cc: 8366342: Key generator and key pair generator tests skipping, but showing as passed
• ... and 20 more: https://git.openjdk.org/jdk17u-dev/compare/f4c80e318a4a72f5308310d352e5504414716fa4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr Pushed as commit e78cfbe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.