Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 28, 2025

I backport this for parity with 17.0.18-oracle.

Omitted test/jdk/sun/security/pkcs11/KeyStore/CertChainRemoval.java
That test was added by https://bugs.openjdk.org/browse/JDK-8301154 SunPKCS11 KeyStore deleteEntry results in dangling PrivateKey entries.
Actually a bugfix that sounds desireable for 17, but let"s not deviate from Oracle VM here.

Further same copyright as in 21.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8366159 needs maintainer approval

Issue

  • JDK-8366159: SkippedException is treated as a pass for pkcs11/KeyStore, pkcs11/SecretKeyFactory and pkcs11/SecureRandom (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4123/head:pull/4123
$ git checkout pull/4123

Update a local copy of the PR:
$ git checkout pull/4123
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4123/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4123

View PR using the GUI difftool:
$ git pr show -t 4123

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4123.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 28, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 28, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title backport 166ef5e7b1c6d6a9f0f1f29fedb7f65b94f53119 8366159: SkippedException is treated as a pass for pkcs11/KeyStore, pkcs11/SecretKeyFactory and pkcs11/SecureRandom Oct 28, 2025
@openjdk
Copy link

openjdk bot commented Oct 28, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Oct 28, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 28, 2025

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree.

@openjdk
Copy link

openjdk bot commented Oct 29, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants