8366159: SkippedException is treated as a pass for pkcs11/KeyStore, pkcs11/SecretKeyFactory and pkcs11/SecureRandom #4123
+46
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I backport this for parity with 17.0.18-oracle.
Omitted test/jdk/sun/security/pkcs11/KeyStore/CertChainRemoval.java
That test was added by https://bugs.openjdk.org/browse/JDK-8301154 SunPKCS11 KeyStore deleteEntry results in dangling PrivateKey entries.
Actually a bugfix that sounds desireable for 17, but let"s not deviate from Oracle VM here.
Further same copyright as in 21.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4123/head:pull/4123$ git checkout pull/4123Update a local copy of the PR:
$ git checkout pull/4123$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4123/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4123View PR using the GUI difftool:
$ git pr show -t 4123Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4123.diff
Using Webrev
Link to Webrev Comment