8225377: type annotations are not visible to javac plugins across compilation boundaries #4124
+303
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JDK-8341779 is a redo of the backport of JDK-8323093, see also discussion in CSR JDK-8346471.
JDK-8341779 was backported to JDK 21u and released in 21.0.8, as discussed in the CSR this PR proposes integrating it into a future 17u release now that 21.0.8 has been released.
Similar to JDK-8360406 for 21u, a future backport will disable this logic for 17u by default, and optionally allow the fix to be enabled with
-XDaddTypeAnnotationsToSymbol.Progress
Warning
8225377: type annotations are not visible to javac plugins across compilation boundariesIssue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4124/head:pull/4124$ git checkout pull/4124Update a local copy of the PR:
$ git checkout pull/4124$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4124/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4124View PR using the GUI difftool:
$ git pr show -t 4124Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4124.diff
Using Webrev
Link to Webrev Comment