Skip to content

Conversation

@cushon
Copy link
Contributor

@cushon cushon commented Oct 28, 2025

JDK-8341779 is a redo of the backport of JDK-8323093, see also discussion in CSR JDK-8346471.

JDK-8341779 was backported to JDK 21u and released in 21.0.8, as discussed in the CSR this PR proposes integrating it into a future 17u release now that 21.0.8 has been released.

Similar to JDK-8360406 for 21u, a future backport will disable this logic for 17u by default, and optionally allow the fix to be enabled with -XDaddTypeAnnotationsToSymbol.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires a CSR request matching fixVersion 17.0.18 to be approved (needs to be created)
  • JDK-8225377 needs maintainer approval

Warning

 ⚠️ Found leading lowercase letter in issue title for 8225377: type annotations are not visible to javac plugins across compilation boundaries

Issue

  • JDK-8225377: type annotations are not visible to javac plugins across compilation boundaries (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4124/head:pull/4124
$ git checkout pull/4124

Update a local copy of the PR:
$ git checkout pull/4124
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4124/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4124

View PR using the GUI difftool:
$ git pr show -t 4124

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4124.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 28, 2025

👋 Welcome back cushon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 28, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport de6667cf11aa59d1bab78ae5fb235ea0b901d5c4 8225377: type annotations are not visible to javac plugins across compilation boundaries Oct 28, 2025
@openjdk
Copy link

openjdk bot commented Oct 28, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 28, 2025
@openjdk
Copy link

openjdk bot commented Oct 28, 2025

At least one of the issues associated with this backport has a resolved CSR for a different version. As this means that this backport may also need a CSR, the csr label is being added to this pull request to signal this potential requirement. The command /csr unneeded can be used to remove the label in case a CSR is not needed.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Oct 28, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 28, 2025

Webrevs

@cushon cushon marked this pull request as draft October 28, 2025 16:23
@openjdk openjdk bot removed the rfr Pull request is ready for review label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required csr Pull request needs approved CSR before integration

Development

Successfully merging this pull request may close these issues.

1 participant