Skip to content

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Oct 28, 2025

Need this to unblock MacOS compiler update in GHA.

Partially backports original openjdk/jdk@b06f1b1. There are lots of conflicts, because:

  1. The original JDK-8294314 that added more verbose build warnings is not in 17u-dev yet.
  2. The JDK-8292054 that added the /test/hotspot/gtest/runtime/test_signals.cpp is also not present in 17u-dev.

Additional testing:

  • Linux AArch64 server fastdebug, all
  • Linux x86_64 server fastdebug, all

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8294594 needs maintainer approval

Issue

  • JDK-8294594: Fix cast-function-type warnings in signal handling code (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4125/head:pull/4125
$ git checkout pull/4125

Update a local copy of the PR:
$ git checkout pull/4125
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4125/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4125

View PR using the GUI difftool:
$ git pr show -t 4125

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4125.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 28, 2025

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 28, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport b06f1b149c8f8a49d4e42c4b782a4b3a22aa79f6 8294594: Fix cast-function-type warnings in signal handling code Oct 28, 2025
@openjdk
Copy link

openjdk bot commented Oct 28, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Oct 28, 2025
@shipilev shipilev force-pushed the JDK-8294594-sr-warnings branch from 66373c7 to c0a427b Compare October 29, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base

Development

Successfully merging this pull request may close these issues.

1 participant