8366342: Key generator and key pair generator tests skipping, but showing as passed

[GoeLin]

I backport this for parity with 17.0.18-oracle.

Clean backport from 21, but skipped two files:

test/jdk/sun/security/pkcs11/KeyGenerator/TestAES.java was added by
https://bugs.openjdk.org/browse/JDK-8267319: Use larger default key sizes and algorithms based on CNSA

test/jdk/sun/security/pkcs11/KeyPairGenerator/TestDefaultDHPrivateExpSize.java was added by
https://bugs.openjdk.org/browse/JDK-8295425: Match the default priv exp length between SunPKCS11 and other JDK providers

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8366342 needs maintainer approval

Issue

• JDK-8366342: Key generator and key pair generator tests skipping, but showing as passed (Bug - P4 - Approved)

Reviewers

• Ralf Schmelter (@schmelter-sap - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4126/head:pull/4126
$ git checkout pull/4126

Update a local copy of the PR:
$ git checkout pull/4126
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4126/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4126

View PR using the GUI difftool:
$ git pr show -t 4126

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4126.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366342: Key generator and key pair generator tests skipping, but showing as passed

Reviewed-by: rschmelter

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• d167b4d: 8354465: Open some JTable bugs 8
• b802991: 8354341: Open some JTable bugs 7
• be5ae4c: 8363676: [GCC static analyzer] missing return value check of malloc in OGLContext_SetTransform
• ... and 4 more: https://git.openjdk.org/jdk17u-dev/compare/63406ab4693d2b0612583661075a3ccdb14b4bf1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (811fdc97)

[schmelter-sap]

The change in TestKeyGenerator.java seems strange, but since it's in the original PR too, I'll let it slide ;)

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[GoeLin]

Thanks for the reviews!