8294591: Fix cast-function-type warning in TemplateTable

[shipilev]

Need this to unblock MacOS compiler update in GHA.

Partially backports original openjdk/jdk@fc61658. There is a conflict, because the original JDK-8294314 that added more verbose build warnings is not in 17u-dev yet. If we backport that one later, we can remove the warning blocks related to these files.

Additional testing:

• Linux AArch64 server fastdebug, all
• Linux x86_64 server fastdebug, all

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8294591 needs maintainer approval

Issue

• JDK-8294591: Fix cast-function-type warning in TemplateTable (Enhancement - P4 - Approved)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4127/head:pull/4127
$ git checkout pull/4127

Update a local copy of the PR:
$ git checkout pull/4127
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4127/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4127

View PR using the GUI difftool:
$ git pr show -t 4127

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4127.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294591: Fix cast-function-type warning in TemplateTable

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

• 846d334: 8327071: [Testbug] g-tests for cgroup leave files in /tmp on linux
• 424eeab: 8354233: Open some JTable bugs 6
• 5d35f53: 8270083: -Wnonnull errors happen with GCC 11.1.1
• ... and 12 more: https://git.openjdk.org/jdk17u-dev/compare/be5ae4cb0e9df4df3e07de2364359b442a42b184...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (e35becda)

[TheRealMDoerr]

Backport looks fine.

[openjdk]

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[shipilev]

/approval request Backporting this to unblock MacOS compiler update. The patch does not apply cleanly because JDK-8294314 is not in 17u; this is trivially resolved. The patch has no bug-tail after more than 3 years in mainline, and it passes all tests.

[openjdk]

@shipilev
8294591: The approval request has been created successfully.

[mrserb]

JDK-8294314 is not in 17u

backport of that one is in progress: #4143

[shipilev]

Thanks, I'll integrate this one, and then work on the rest.

/integrate

[openjdk]

Going to push as commit 98532ee.
Since your change was applied there have been 25 commits pushed to the master branch:

• dbfdc50: 8353832: Opensource FontClass, Selection and Icon tests
• 0da7c43: 8354095: Open some JTable bugs 5
• 3f884a9: 8364660: ClassVerifier::ends_in_athrow() should be removed
• ... and 22 more: https://git.openjdk.org/jdk17u-dev/compare/be5ae4cb0e9df4df3e07de2364359b442a42b184...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 98532ee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.