8270083: -Wnonnull errors happen with GCC 11.1.1

[mrserb]

Hi all,

This pull request contains a backport of commit 68b6e11e from the openjdk/jdk repository.

The commit being backported was authored by Yasumasa Suenaga on 10 Jul 2021 and was reviewed by Erik Joelsson, Dean Long and Kim Barrett.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8270083 needs maintainer approval

Issue

• JDK-8270083: -Wnonnull errors happen with GCC 11.1.1 (Bug - P4)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4132/head:pull/4132
$ git checkout pull/4132

Update a local copy of the PR:
$ git checkout pull/4132
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4132/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4132

View PR using the GUI difftool:
$ git pr show -t 4132

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4132.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mrserb]

This patch, along with several similar ones, was removed from the mainline as part of JDK-8291895. That issue also references other related tickets titled “Undefined Behaviour in class XX,” which as of now remain unfixed in 17u. Therefore, I think this patch should be merged first, as it will also simplify future backports related to Xcode 16+.

@shipilev @theRealAph please take a look

[openjdk]

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (09ed1b90)

[shipilev]

Yes, this looks reasonable. Toolchain support backports are annoying, but unfortunately necessary for long-term maintenance.