Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Nov 28, 2025

I backport this for parity with 21.0.11-oracle.

Needed to resolve and adapt larger parts of ResumeChecksServer.java as https://bugs.openjdk.org/browse/JDK-8357033 is not in 21.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8333857 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8333857: Test sun/security/ssl/SSLSessionImpl/ResumeChecksServer.java failed: Existing session was used (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2494/head:pull/2494
$ git checkout pull/2494

Update a local copy of the PR:
$ git checkout pull/2494
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2494/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2494

View PR using the GUI difftool:
$ git pr show -t 2494

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2494.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 28, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@GoeLin GoeLin changed the title Goetz backport 8327980 backport e6ebefaa404daa4160bdc1c5d9c954c040e2c0c2 Nov 28, 2025
@openjdk
Copy link

openjdk bot commented Nov 28, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title backport e6ebefaa404daa4160bdc1c5d9c954c040e2c0c2 8333857: Test sun/security/ssl/SSLSessionImpl/ResumeChecksServer.java failed: Existing session was used Nov 28, 2025
@openjdk
Copy link

openjdk bot commented Nov 28, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Nov 28, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 28, 2025

Webrevs

params.setNeedClientAuth(true);
params.setAlgorithmConstraints(new NoSig(
first ? "ecdsa_secp521r1_sha512" :
"ecdsa_secp384r1_sha384"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems those constraints ecdsa_secp521r1_sha512 / ecdsa_secp384r1_sha384 came in with https://bugs.openjdk.org/browse/JDK-8357033 .
Have you checked if this is okay ?

@MBaesken
Copy link
Member

MBaesken commented Dec 4, 2025

Looks mostly okay; not 100% sure about the SIGNATURE_SCHEME constraints settings, do you want them here?

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received and removed approval Requires approval; will be removed when approval is received labels Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants