-
Notifications
You must be signed in to change notification settings - Fork 147
8333857: Test sun/security/ssl/SSLSessionImpl/ResumeChecksServer.java failed: Existing session was used #2494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
| params.setNeedClientAuth(true); | ||
| params.setAlgorithmConstraints(new NoSig( | ||
| first ? "ecdsa_secp521r1_sha512" : | ||
| "ecdsa_secp384r1_sha384")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems those constraints ecdsa_secp521r1_sha512 / ecdsa_secp384r1_sha384 came in with https://bugs.openjdk.org/browse/JDK-8357033 .
Have you checked if this is okay ?
|
Looks mostly okay; not 100% sure about the SIGNATURE_SCHEME constraints settings, do you want them here? |
I backport this for parity with 21.0.11-oracle.
Needed to resolve and adapt larger parts of ResumeChecksServer.java as https://bugs.openjdk.org/browse/JDK-8357033 is not in 21.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2494/head:pull/2494$ git checkout pull/2494Update a local copy of the PR:
$ git checkout pull/2494$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2494/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2494View PR using the GUI difftool:
$ git pr show -t 2494Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2494.diff
Using Webrev
Link to Webrev Comment