Skip to content

Conversation

@MBaesken
Copy link
Member

@MBaesken MBaesken commented Dec 17, 2025


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8372588 needs maintainer approval

Issue

  • JDK-8372588: [asan] serviceability/sa/TestJmapCore.java and TestJmapCoreMetaspace.java fail after recent improvements (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/102/head:pull/102
$ git checkout pull/102

Update a local copy of the PR:
$ git checkout pull/102
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/102/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 102

View PR using the GUI difftool:
$ git pr show -t 102

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/102.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 17, 2025

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 17, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport a6bc9b3ba50c5d669213f082a32e30c9ab2f923d 8372588: [asan] serviceability/sa/TestJmapCore.java and TestJmapCoreMetaspace.java fail after recent improvements Dec 17, 2025
@openjdk
Copy link

openjdk bot commented Dec 17, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Dec 17, 2025
@openjdk
Copy link

openjdk bot commented Dec 17, 2025

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 17, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 17, 2025

Webrevs

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received and removed approval Requires approval; will be removed when approval is received labels Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant