-
Notifications
You must be signed in to change notification settings - Fork 26
8373625: CPUTimeCounters creates a total counter for unsupported GCs #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back jyma22! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request Backporting this patch fixes the misleading GC CPU time counter issue where Patch applies cleanly to 25u. Included test passes. Ran tier1-4 with no regressions observed. |
|
HI @jyma22 |
CPUTimeCountersunconditionally createsCPUTimeGroups::CPUTimeType::gc_total. Since only Parallel and G1 are supported by this framework/class, this leads to publishing a counter that always resolves to 0. This may be contradictory for an end-user especially so as we now support logging GC CPU time for any GC inside Hotspot. For an example using-XX:+UseZGC -Xlog:cpuwe getBut
jcmd $(pgrep -n java) PerfCounter.print | grep -E "sun.threads.total_gc_cpu_time"prints:sun.threads.total_gc_cpu_time=0.Testing: passed tier1-4
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/104/head:pull/104$ git checkout pull/104Update a local copy of the PR:
$ git checkout pull/104$ git pull https://git.openjdk.org/jdk25u-dev.git pull/104/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 104View PR using the GUI difftool:
$ git pr show -t 104Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/104.diff
Using Webrev
Link to Webrev Comment