Skip to content

Conversation

@rm-gh-8
Copy link
Contributor

@rm-gh-8 rm-gh-8 commented Dec 17, 2025

Backporting JDK-8358756: [s390x] Test StartupOutput.java crash due to CodeCache size.

For parity with Oracle JDK.

This fix increases the initial code cache size to ensure adequate space for interpreter mode execution.

Please note that I am unable to run a validation test on the s390x platform due to unavailable hardware. PR #106 depends on this PR.

Ran the specific test on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

(Passed) - make test TEST=test/hotspot/jtreg/compiler/startup/StartupOutput.java

Results are attached:

linux-aarch64-specific-test.log
linux-x64-specific-test.log
macos-aarch64-specific-test.log
windows-x64-specific-test.log


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8358756 needs maintainer approval

Issue

  • JDK-8358756: [s390x] Test StartupOutput.java crash due to CodeCache size (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/105/head:pull/105
$ git checkout pull/105

Update a local copy of the PR:
$ git checkout pull/105
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/105/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 105

View PR using the GUI difftool:
$ git pr show -t 105

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/105.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 17, 2025

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 17, 2025

@rm-gh-8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358756: [s390x] Test StartupOutput.java crash due to CodeCache size

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 78d50c02152d3d02953cc468d50c7c40c43c1527 8358756: [s390x] Test StartupOutput.java crash due to CodeCache size Dec 17, 2025
@openjdk
Copy link

openjdk bot commented Dec 17, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Dec 17, 2025
@openjdk
Copy link

openjdk bot commented Dec 17, 2025

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 17, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 17, 2025

Webrevs

@rm-gh-8
Copy link
Contributor Author

rm-gh-8 commented Dec 17, 2025

/approval request for backport of JDK-8358756: [s390x] Test StartupOutput.java crash due to CodeCache size.

For parity with Oracle JDK.

This fix increases the initial code cache size to ensure adequate space for interpreter mode execution.

Low risk - fix addresses a crash, but requires validation on memory-constrained platforms to ensure the increased initial allocation doesn't cause resource issues.

@openjdk
Copy link

openjdk bot commented Dec 17, 2025

@rm-gh-8
8358756: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant