8371944: AOT configuration is corrupted when app closes System.out

[shipilev]

Backporting to make AOT more reliable and for 25.0.3-oracle parity.

The change is not clean, because two major rewrites are not present in jdk25u-dev:

• JDK-8365932: Implementation of JEP 516: Ahead-of-Time Object Caching with Any GC
• JDK-8366475: Rename MetaspaceShared class to AOTMetaspace

Therefore, I had to reapply some chunks by hand. Please take a careful look against the original changeset.

Additional testing:

• MacOS AArch64 server fastdebug, runtime/cds passes

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8371944 needs maintainer approval

Issue

• JDK-8371944: AOT configuration is corrupted when app closes System.out (Bug - P3 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)
• Ioi Lam (@iklam - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/93/head:pull/93
$ git checkout pull/93

Update a local copy of the PR:
$ git checkout pull/93
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/93/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 93

View PR using the GUI difftool:
$ git pr show -t 93

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/93.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371944: AOT configuration is corrupted when app closes System.out

Reviewed-by: phh, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• 43f752f: 8293484: AArch64: TestUseSHA512IntrinsicsOptionOnSupportedCPU.java fails on CPU with SHA512 feature support
• 04bd246: 8366938: Test runtime/handshake/HandshakeTimeoutTest.java crashed
• b4041e3: 8358801: javac produces class that does not pass verifier.
• ... and 10 more: https://git.openjdk.org/jdk25u-dev/compare/8f2b5a6bf3a8502360ff194549d305d7f582ad48...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[shipilev]

serviceability/jvmti/RedefineClasses/ClassVersionAfterRedefine failure is due to #94

[mlbridge]

Webrevs

• 01: Full - Incremental (8a6b110c)
• 00: Full (2576b0de)

[openjdk]

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[shipilev]

/approval request Makes AOT more reliable and for 25.0.3-oracle parity. Does not apply cleanly, adaptations are required, see 25u-dev PR. runtime/cds test pass. Risk is medium-low: affects CDS dumping path, which is usually not a production phase.

[shipilev]

@iklam, you might want to sanity check this :)

[openjdk]

@shipilev
8371944: The approval request has been created successfully.

[iklam]

LGTM

[shipilev]

Thanks for reviews, folks! Now waiting for push approval.

[shipilev]

Push approval granted.

/integrate

[openjdk]

Going to push as commit f18b1ac.
Since your change was applied there have been 17 commits pushed to the master branch:

• c3eecc0: 8370966: Create regression test for the hierarchical memory limit fix in JDK-8370572
• 5a08f94: 8370572: Cgroups hierarchical memory limit is not honored after JDK-8322420
• ced6e95: 8369911: Test sun/java2d/marlin/ClipShapeTest.java#CubicDoDash, #Cubic and #Poly fail intermittent
• ... and 14 more: https://git.openjdk.org/jdk25u-dev/compare/8f2b5a6bf3a8502360ff194549d305d7f582ad48...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit f18b1ac.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.