-
Notifications
You must be signed in to change notification settings - Fork 26
8372609: Bug4944439 does not enforce locale correctly #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
|
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request Fixes the test bug that manifests in JDK 25u as well. Applies cleanly. Test now runs well on machines where it used to fail. Patch is relatively recent, but fixes a known test bug. Risk is low: test-only patch. |
Webrevs
|
|
Push approval granted. /integrate |
|
Going to push as commit 101e8ed.
Your commit was automatically rebased without conflicts. |
Caught this testbug in JDK 25u testing on my machines.
Additional testing:
java/text/Formatused to fail, now passesProgress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/98/head:pull/98$ git checkout pull/98Update a local copy of the PR:
$ git checkout pull/98$ git pull https://git.openjdk.org/jdk25u-dev.git pull/98/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 98View PR using the GUI difftool:
$ git pr show -t 98Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/98.diff
Using Webrev
Link to Webrev Comment