8367782: VerifyJarEntryName.java: Fix modifyJarEntryName to operate on bytes and re-introduce verifySignatureEntryName

[franferrax]

Hi, I'm proposing this test-only improvement for consistency with the older releases, where I'm doing backports of the main issue (JDK-8339280, openjdk/jdk@bbd5b17) and also including this version of the test. Those backports are openjdk/jdk21u-dev#2235, openjdk/jdk17u-dev#3954, openjdk/jdk11u-dev#3098 and openjdk/jdk8u-dev#699.

The backport is clean and improves the reliability and coverage of the VerifyJarEntryName.java test.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8367782 needs maintainer approval

Issue

• JDK-8367782: VerifyJarEntryName.java: Fix modifyJarEntryName to operate on bytes and re-introduce verifySignatureEntryName (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/221/head:pull/221
$ git checkout pull/221

Update a local copy of the PR:
$ git checkout pull/221
$ git pull https://git.openjdk.org/jdk25u.git pull/221/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 221

View PR using the GUI difftool:
$ git pr show -t 221

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/221.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fferrari! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@franferrax This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8367782: VerifyJarEntryName.java: Fix modifyJarEntryName to operate on bytes and re-introduce verifySignatureEntryName

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 00be643: 8367031: [backout] Change java.time month/day field types to 'byte'
• cefd945: 8365919: Replace currentTimeMillis with nanoTime in Stresser.java
• 147ed00: 8357064: cds/appcds/ArchiveRelocationTest.java failed with missing expected output
• ... and 8 more: https://git.openjdk.org/jdk25u/compare/d9981960c58bbb7555d53b31154d6f1d5006c067...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @franferrax This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[franferrax]

/approval request I'm proposing this test-only improvement for consistency with the older releases, where I'm doing backports of the main issue (JDK-8339280) and also including this final version of the test. It touches a single test file to improve its reliability and coverage.

[openjdk]

@franferrax
8367782: The approval request has been created successfully.

[mlbridge]

Webrevs

• 00: Full (1cfee0d5)

[franferrax]

/integrate

[openjdk]

@franferrax
Your change (at version 1cfee0d) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit c2d7960.
Since your change was applied there have been 11 commits pushed to the master branch:

• 00be643: 8367031: [backout] Change java.time month/day field types to 'byte'
• cefd945: 8365919: Replace currentTimeMillis with nanoTime in Stresser.java
• 147ed00: 8357064: cds/appcds/ArchiveRelocationTest.java failed with missing expected output
• ... and 8 more: https://git.openjdk.org/jdk25u/compare/d9981960c58bbb7555d53b31154d6f1d5006c067...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @franferrax Pushed as commit c2d7960.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[franferrax]

Thanks @phohensee!