Skip to content

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Oct 25, 2025

Hi all,

This pull request contains a backport of commit ed153ee2 from the openjdk/jdk repository.

The commit being backported was authored by Sergey Bylokhov on 21 Oct 2025 and was reviewed by Harshitha Onkar.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8369032 needs maintainer approval

Issue

  • JDK-8369032: Add test to ensure serialized ICC_Profile stores only necessary optional data (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/338/head:pull/338
$ git checkout pull/338

Update a local copy of the PR:
$ git checkout pull/338
$ git pull https://git.openjdk.org/jdk25u.git pull/338/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 338

View PR using the GUI difftool:
$ git pr show -t 338

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/338.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 25, 2025

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 25, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport ed153ee2c4614c814da92c23c4741eed68ce1a0c 8369032: Add test to ensure serialized ICC_Profile stores only necessary optional data Oct 25, 2025
@openjdk
Copy link

openjdk bot commented Oct 25, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 25, 2025
@mrserb mrserb marked this pull request as ready for review October 29, 2025 18:18
@openjdk
Copy link

openjdk bot commented Oct 29, 2025

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 29, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 29, 2025

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Oct 29, 2025

/approval request
Clean backport. Adds a new test to cover a specific serialization use case. Verified to work correctly on JDK 25.

@openjdk
Copy link

openjdk bot commented Oct 29, 2025

@mrserb
8369032: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant