-
Notifications
You must be signed in to change notification settings - Fork 173
8321489: Update LCMS to 2.16 #679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
|
Additional testing: java/awt/color/* and sun/java2d/cmm/* tests passed successfully |
5517fec to
ee13589
Compare
|
@kvergizova This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a |
|
The parent pull request that this pull request depends on has been closed without being integrated and the target branch of this pull request has been updated as the previous branch was deleted. This means that changes from the parent pull request will start to show up in this pull request. If closing the parent pull request was done in error, it will need to be re-opened and this pull request will need to manually be retargeted again. |
I'd like to backport it for parity with Oracle 8u.
11u patch applies almost cleanly, except for a license update in THIRD_PARTY_README instead of lcms.md.
GHA testing passes without regressions, test failures look unrelated. Additionally tested manually with J2Ddemo.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/679/head:pull/679$ git checkout pull/679Update a local copy of the PR:
$ git checkout pull/679$ git pull https://git.openjdk.org/jdk8u-dev.git pull/679/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 679View PR using the GUI difftool:
$ git pr show -t 679Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/679.diff
Using Webrev
Link to Webrev Comment