-
Notifications
You must be signed in to change notification settings - Fork 173
8353657: [8u] Test tools/launcher/VersionCheck.java fails with debug build #685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
Webrevs
|
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
GHA report several fails:
|
Thanks for the reviews @theRealAph /approval request Fix the test bug which will cause test fail with jdk fastdebug build. Change has been verified locally, test-fix only, no risk. |
@sendaoYan |
Hi all,
Test tools/launcher/VersionCheck.java fails with fastdebug build which report 'jstack.debuginfo: cannot execute binary file'. This failure fixed by JDK-8237192 in jdk15, only a subset of JDK-8237192 to fix this test failure. So it's not suitable to backport JDK-8237192 to jdk8u-dev, then I create this PR to fix this testbug.
This PR skip all the
*.debuginfo
files to check the '-version' or '-J-version'. Change has been verified localy, test-fix only, no risk.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/685/head:pull/685
$ git checkout pull/685
Update a local copy of the PR:
$ git checkout pull/685
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/685/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 685
View PR using the GUI difftool:
$ git pr show -t 685
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/685.diff
Using Webrev
Link to Webrev Comment