Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8299: JDP Tests in core fail if multicast is not possible #611

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

skarsaune
Copy link
Contributor

@skarsaune skarsaune commented Nov 24, 2024

As

JDPClientTest.testChangePacket:95
JDPClientTest.testJDPClient:73
JDPJMXTest.testJDPClient:71

Now reside in common, installCore should skip JDP multicast test when the build file has been called with the flag to avoid JDP multicast tests


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8299: JDP Tests in core fail if multicast is not possible (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/611/head:pull/611
$ git checkout pull/611

Update a local copy of the PR:
$ git checkout pull/611
$ git pull https://git.openjdk.org/jmc.git pull/611/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 611

View PR using the GUI difftool:
$ git pr show -t 611

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/611.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 24, 2024

👋 Welcome back skarsaune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 24, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr label Nov 24, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 24, 2024

Webrevs

@RealCLanger
Copy link
Collaborator

Hi, @skarsaune. You need to create/reference another bug but not JMC-7539 since that one is already closed.

@skarsaune skarsaune changed the title JMC-7539: Ensure installCore respects avoiding JDP tests JMC-8299: JDP Tests in core fail if multicast is not possible Nov 28, 2024
@openjdk openjdk bot changed the title JMC-8299: JDP Tests in core fail if multicast is not possible 8299: JDP Tests in core fail if multicast is not possible Nov 28, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 23, 2024

@skarsaune This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants