Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316: Update to 10 #623

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

thegreystone
Copy link
Member

@thegreystone thegreystone commented Jan 12, 2025

Updating the main branch to be the upcoming JMC 10.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/623/head:pull/623
$ git checkout pull/623

Update a local copy of the PR:
$ git checkout pull/623
$ git pull https://git.openjdk.org/jmc.git pull/623/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 623

View PR using the GUI difftool:
$ git pr show -t 623

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/623.diff

Using Webrev

Link to Webrev Comment

@thegreystone thegreystone requested a review from aptmac January 12, 2025 16:29
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 12, 2025

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 12, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr label Jan 12, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 12, 2025

Webrevs

@thegreystone
Copy link
Member Author

@aptmac - not quite sure why the check copyright script is complaining.

@aptmac
Copy link
Member

aptmac commented Jan 12, 2025

@aptmac - not quite sure why the check copyright script is complaining.

It's complaining about: Requires update: application/org.openjdk.jmc.feature.pde/pom.xml

Copyright (c) 2018, 2024, Oracle and/or its affiliates. All rights reserved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants