fix(e2b): align timeout lifecycle semantics#629
Draft
AiRanthem wants to merge 1 commit into
Draft
Conversation
- Extend PauseTime and ShutdownTime independently on connect and resume for auto-pause sandboxes. - Anchor create timeouts after claim or clone finishes instead of at request start. - Treat dead claimed sandboxes as not found in DescribeSandbox by using live-state lookup. Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@AiRanthem: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Timeout writes previously reconstructed lifecycle state from incomplete inputs, which could overwrite the other timeout dimension or apply the wrong paused-retention policy. The updated flow merges timeout changes against fresh sandbox state and keeps controller and sandbox-manager policy boundaries separate.
Impact
E2B timeout operations now retain the unaffected lifecycle deadline while updating the requested timeout, including pause/resume and sandbox creation-related paths.
Validation