Doc: FCP templates API calls and other fixes#843
Merged
mfriesenegger merged 5 commits intoopenmainframeproject:masterfrom Feb 9, 2025
Merged
Doc: FCP templates API calls and other fixes#843mfriesenegger merged 5 commits intoopenmainframeproject:masterfrom
mfriesenegger merged 5 commits intoopenmainframeproject:masterfrom
Conversation
Bischoff
force-pushed
the
doc-fcp-templates
branch
2 times, most recently
from
a36ba74 to
5056e09
Compare
Bischoff
force-pushed
the
doc-fcp-templates
branch
25 times, most recently
from
3186383 to
381a63f
Compare
Bischoff
force-pushed
the
doc-fcp-templates
branch
2 times, most recently
from
7d05a10 to
549a979
Compare
Bischoff
changed the title
Bischoff
force-pushed
the
doc-fcp-templates
branch
7 times, most recently
from
2a3234d to
1c85fbd
Compare
Bischoff
force-pushed
the
doc-fcp-templates
branch
from
1c85fbd to
4cab8a8
Compare
mfriesenegger
force-pushed
the
doc-fcp-templates
branch
2 times, most recently
from
f478247 to
909117e
Compare
mfriesenegger
requested changes
Feb 3, 2025
Collaborator
mfriesenegger
left a comment
mfriesenegger
left a comment
There was a problem hiding this comment.
Thank you for the great work on this! I used the tox -e docs command that you shared with me to generate a readable local copy for myself. I have pointed out a number of items that should be updated before merging this PR.
Collaborator
Bischoff
force-pushed
the
doc-fcp-templates
branch
from
909117e to
bc09954
Compare
Signed-off-by: Eric Bischoff <ebischoff@suse.com>
Signed-off-by: Eric Bischoff <ebischoff@suse.com>
Signed-off-by: Eric Bischoff <ebischoff@suse.com>
Bischoff
force-pushed
the
doc-fcp-templates
branch
from
bc09954 to
268a9b0
Compare
Contributor
Author
|
Suggestions applied, please review again. |
Contributor
Author
@dongyanyang wrote in that issue: "The doc of CRUD of fcp_template and the attach_volume/detach_volume APIs are missing, need to add them." The following API calls were indeed undocumented:
I do not see what I might have missed, but one never knows. I suggest that we close #772, and if we detect a missing doc piece, we reopen a new issue. |
Signed-off-by: Eric Bischoff <ebischoff@suse.com>
Signed-off-by: Eric Bischoff <ebischoff@suse.com>
Bischoff
force-pushed
the
doc-fcp-templates
branch
from
268a9b0 to
3c2fd57
Compare
mfriesenegger
approved these changes
Feb 9, 2025
Collaborator
|
@Bischoff Thank you for all of your work on this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation fixes
Fix typography and English
Fix parameters of existing volume functions
Fixes #772