-
Notifications
You must be signed in to change notification settings - Fork 585
Support MPI parallelism in R2SManager #3632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pshriwise
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small suggestions mainly for clarity here, @paulromano, but it looks nice! Thanks for addressing this!
|
@pshriwise thanks for your review! comments have been addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @paulromano! I'll give this a short 24h cooldown in case anyone else wants to have a look.
Description
This PR makes changes in the
R2SManagerand related classes in order to work properly with MPI parallelism. The changes include:mpiexec ... openmcbecause nestedmpiexeccalls are are not supported.TemporarySessioncontext manager was also updated to work when called in parallelChecklist
I have run clang-format (version 15) on any C++ source files (if applicable)