feat(api): filter with expression language #682
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hekike
changed the title
| @@ -160,9 +213,18 @@ func (resp QueryMeterResponse) Render(_ http.ResponseWriter, _ *http.Request) er | |||
| } | |||
|
|
|||
| // RenderCSV renders the response as CSV. | |||
| func (resp QueryMeterResponse) RenderCSV(w http.ResponseWriter, r *http.Request, groupByKeys []string, meterIDOrSlug string) { | |||
| func (resp QueryMeterResponse) RenderCSV(w http.ResponseWriter, r *http.Request, _groupByKeys []string, meterIDOrSlug string) { | |||
There was a problem hiding this comment.
Suggested change
| func (resp QueryMeterResponse) RenderCSV(w http.ResponseWriter, r *http.Request, _groupByKeys []string, meterIDOrSlug string) { | |
| func (resp QueryMeterResponse) RenderCSV(w http.ResponseWriter, r *http.Request, groupByKeys []string, meterIDOrSlug string) { |
| records := [][]string{} | ||
|
|
||
| // Filter out the subject from the group by keys | ||
| groupByKeys := []string{} |
There was a problem hiding this comment.
Suggested change
| groupByKeys := []string{} | |
| dataGroupByKeys := make([]string, 0, len(groupByKeys)) |
The slice will have at most the same length as groupByKeys
| if k == "subject" { | ||
| continue | ||
| } | ||
| groupByKeys = append(groupByKeys, k) |
There was a problem hiding this comment.
Suggested change
| groupByKeys = append(groupByKeys, k) | |
| dataGroupByKeys = append(dataGroupByKeys, k) |
Oltier
reviewed
Mar 27, 2024
There was a problem hiding this comment.
There's a typo in the file name :) filLter.go
|
Closing due to inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example
http://localhost:8888/api/v1/meters/api_requests_total/query?windowSize=HOUR&groupBy=route&groupBy=subject&groupBy=method&filter[subject]={"$in":["customer-1","customer-2"]}&filter[route]={"$eq":"/hello"}&filter[method]={"$nin":["POST","DELETE"]}`
One of the biggest values of JSON-based filters is that we can validate them with OpenAPI. However, for some reason, this validation doesn't work for query params. It works if it's a POST payload.