Disable write batching for PSQL #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: batches of transactions are accumulated before an EOF of trace file is encountered. Given files are written in parallel by the fetcher, this may lead to potentially indefinite accumulation of batches without commitment. Solution: disable batching for Postgresql (as it was originally introduced as a necessary optimization for sqlite).
This change should be accompanied by a trigger in PSQL
Reaosn: quite expensive to support, not much of use
Problem: status handling and metrics recacluclation is very expensive for the stup of hundreds of nodes. Solution: move out block trace updates to PSQL triggers, skip doing updates of distributions.
Introduce additional CLI option to override host components within URLs provided by the Uptime backend service.
Update Dockerfile
Improve Dockerfile
Pass the --handle-status-change CLI arg down to consumer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: batches of transactions are accumulated before an EOF of trace file is encountered. Given files are written in parallel by the fetcher, this may lead to potentially indefinite accumulation of batches without commitment.
Solution: disable batching for Postgresql (as it was originally introduced as a necessary optimization for sqlite).