Skip to content

Conversation

suubi-joshua
Copy link

Linked Issue: https://openmrs.atlassian.net/browse/HIE-5

Added explicit configuration for Client Registry Events enablement:

Added new global property constant GP_CLIENT_REGISTRY_EVENTS_ENABLE
Introduced eventsEnabled configuration field
Events processing now requires both explicit enablement and valid server URL configuration
Improves configuration clarity and control over event-based functionality

@suubi-joshua
Copy link
Author

@samuelmale is this something close to what you were thinking of?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method isClientRegistryEventsEnabled() correctly checks if events are enabled, but should we also consider fetching this value from a global property instead of just relying on environment variables?"
🔹 "Instead of using Boolean.TRUE.equals(eventsEnabled), you could simply use Boolean.TRUE.equals(eventsEnabled) && StringUtils.isNotBlank(getClientRegistryServerUrl()) inline to improve readability."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants