Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add german localisation #15

Merged
merged 6 commits into from
Dec 4, 2023
Merged

Add german localisation #15

merged 6 commits into from
Dec 4, 2023

Conversation

Bios-Marcel
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Nov 12, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@Bios-Marcel Bios-Marcel force-pushed the feature/add_german_localisation_data branch from 582f611 to f3e574d Compare November 12, 2023 12:51
pkfln
pkfln previously requested changes Nov 12, 2023
View reviewed changes
Copy link
Member

@pkfln pkfln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls fix

@Bios-Marcel Bios-Marcel force-pushed the feature/add_german_localisation_data branch from a23866f to 355b0d2 Compare November 13, 2023 16:06
@Bios-Marcel Bios-Marcel force-pushed the feature/add_german_localisation_data branch from e8a395a to 43c5cbd Compare November 18, 2023 12:15
@Bios-Marcel Bios-Marcel force-pushed the feature/add_german_localisation_data branch from 43c5cbd to bafa880 Compare November 18, 2023 23:36
@Southclaws
Copy link
Contributor

Southclaws commented Dec 4, 2023 •
edited

LGTM

@AmyrAhmady needs rebase but not sure what's required without cloning - should be simple though as it looks like an all-or-nothing merge

@AmyrAhmady AmyrAhmady merged commit 6255df9 into master Dec 4, 2023
2 checks passed
@AmyrAhmady AmyrAhmady deleted the feature/add_german_localisation_data branch December 4, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkfln pkfln pkfln left review comments

@AmyrAhmady AmyrAhmady AmyrAhmady approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Bios-Marcel @CLAassistant @Southclaws @pkfln @AmyrAhmady