Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate main pages #984

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ulasbayraktar
Copy link
Member

No description provided.

Copy link
Member

@adib-yg adib-yg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found several issues.

"server-sumbitted": "serverCodeHn} is added to our pending list. If it's not available after maximum 48 hours, you can contact us on Discord!",

Missing { "serverCodeHn}


"Partners (BETA TESTERS)" : "Partnerler (BETA TESTERLER)",

"Partnerler (BETA TESTERLER)" is Turkish and it repeated in all translation files.


"Documentation": "Documentatio",

Documentatio spelling mistake.


"IP/Domain": "AIP/Domain",

AIP to IP


"Change language from English": "Change language from English",

It doesn't need the name of the language.

<ModalHeader>{translateText(locale, "General", `Change language from ${getLanguageName(locale)}`)}</ModalHeader>

So just:

"Change language from ": "Change language from ",

@adib-yg
Copy link
Member

adib-yg commented Apr 8, 2024

I come to the conclusion that this is not good.

  1. The keys are very long. Isn't this better?
"Index": {
  "Getting Started": "Getting started",
  "Fully backwards compatible with existing scripts and clients": "Fully backwards compatible with existing scripts and clients",
  
  "index-text-1": "Getting started",
  "index-text-2": "Fully backwards compatible with existing scripts and clients",

Or like this: https://github.com/openmultiplayer/launcher/blob/master/src/locales/translations/en.ts

  1. Announcements are temporary and old announcement remain in files after replacement. It will be difficult to remove them in the future.

But please don't make any changes for now, let other team members decide.

@AmyrAhmady
Copy link
Member

I'm not entirely sure how I feel about introducing a new way for translations while docs use directory based files
I also know that doing the same as docs for regular pages probably isn't doable, so there's that.

@Southclaws what are your thoughts on this?

@AmyrAhmady AmyrAhmady requested a review from Southclaws April 11, 2024 11:13
@ulasbayraktar
Copy link
Member Author

ulasbayraktar commented Apr 11, 2024

Barnaby had already said that it should be like this @AmyrAhmady (key-value)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants