Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated to be more bids-app like #47

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

bendhouseart
Copy link
Collaborator

@bendhouseart bendhouseart commented Nov 14, 2024

Closes issue #46


📚 Documentation preview 📚: https://petdeface--47.org.readthedocs.build/en/47/

@bendhouseart bendhouseart linked an issue Nov 14, 2024 that may be closed by this pull request
@bendhouseart
Copy link
Collaborator Author

Updating the CLI to conform to the BIDS app spec will cause breaking changes if the older semi-BIDS app inputs --input_dir and --output_dir are used. Should probably add a warning about those being deprecated and/or catching them and substituting them in with the same deprecation warning.

@bendhouseart bendhouseart self-assigned this Nov 14, 2024
@bendhouseart bendhouseart marked this pull request as ready for review November 15, 2024 21:28
@bendhouseart
Copy link
Collaborator Author

CLI aligned with petprep_hmc and petprep_extract_tacs, ready for review.

Copy link
Collaborator

@mnoergaard mnoergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @bendhouseart

@mnoergaard mnoergaard merged commit b27a724 into main Nov 20, 2024
1 check passed
@bendhouseart bendhouseart deleted the 46-standardize-input-names-across-pet-prep-piplines branch December 11, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize Input Names Across PET prep piplines
2 participants