-
Notifications
You must be signed in to change notification settings - Fork 184
Fix Next 16.1 not including skipTrailingSlashRedirect #1072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e02abbe
bump Next
conico974 be45424
Implement patch for Next.js config to include skipTrailingSlashRedirect
conico974 d3f0b44
Refactor patchNextConfig to dynamically locate next.config file and h…
conico974 5cc37c9
changeset
conico974 403e500
linting
conico974 4c1f499
Revert "bump Next"
conico974 6e21c71
fix broken lockfile
conico974 5bdc712
support mts and cts
conico974 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@opennextjs/aws": patch | ||
| --- | ||
|
|
||
| Fix for Next 16.1 config |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 changes: 63 additions & 0 deletions
63
packages/open-next/src/build/patch/patches/patchNextConfig.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| import fs from "node:fs"; | ||
| import path from "node:path"; | ||
| import { buildSync } from "esbuild"; | ||
| import type { CodePatcher } from "../codePatcher"; | ||
|
|
||
| export const patchNextConfig: CodePatcher = { | ||
| name: "patch-next-config", | ||
| patches: [ | ||
| { | ||
| pathFilter: /required\-server\-files\.json$/, | ||
| versions: ">=16.1.0", | ||
| patchCode: async ({ code, buildOptions }) => { | ||
| // Find the next.config file with any supported extension | ||
| const tsExtensions = [".ts", ".mts", ".cts"]; | ||
| const possibleExtensions = [...tsExtensions, ".mjs", ".js", ".cjs"]; | ||
| let configPath: string | undefined; | ||
| let configExtension: string | undefined; | ||
|
|
||
| for (const ext of possibleExtensions) { | ||
| const testPath = path.join(buildOptions.appPath, `next.config${ext}`); | ||
| if (fs.existsSync(testPath)) { | ||
| configPath = testPath; | ||
| configExtension = ext; | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| if (!configPath || !configExtension) { | ||
| throw new Error("Could not find next.config file"); | ||
| } | ||
|
|
||
| let configToImport: string; | ||
|
|
||
| // Only compile if the extension is a TypeScript extension | ||
| if (tsExtensions.includes(configExtension)) { | ||
| buildSync({ | ||
| entryPoints: [configPath], | ||
| outfile: path.join(buildOptions.tempBuildDir, "next.config.mjs"), | ||
| bundle: true, | ||
| format: "esm", | ||
| platform: "node", | ||
| }); | ||
| configToImport = path.join( | ||
| buildOptions.tempBuildDir, | ||
| "next.config.mjs", | ||
| ); | ||
| } else { | ||
| // For .js, .mjs, .cjs, use the file directly | ||
| configToImport = configPath; | ||
| } | ||
|
|
||
| // In next 16.1+ we need to add `skipTrailingSlashRedirect` manually because next removes it from the config | ||
| const originalConfig = (await import(configToImport)).default; | ||
| const config = JSON.parse(code); | ||
| if (config.config.skipTrailingSlashRedirect === undefined) { | ||
| config.config.skipTrailingSlashRedirect = | ||
| originalConfig.skipTrailingSlashRedirect ?? false; | ||
| } | ||
| return JSON.stringify(config, null, 2); | ||
| }, | ||
| }, | ||
| ], | ||
| }; | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: do you think this should be reported as an issue on the Next repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we could, but I think they did it on purpose. Looks like they use define for that now, and I checked, it is defined in the adapter output