fix(installDeps): Ensure symlinks are dereferenced on all Node versions #1074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5a9038a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
vicb
approved these changes
Jan 7, 2026
Contributor
vicb
left a comment
vicb
left a comment
There was a problem hiding this comment.
Thanks @sommeeeer
Definitely +1 for that given the amount of comments on the Node issue.
Any reason why the PR is in draft state?
Contributor
|
|
Contributor
Author
I haven't had time to test it out on a real repo yet. Can do it later tonight |
Contributor
Author
|
This one is ready to ship now! |
Contributor
|
Thanks @sommeeeer ! |
This was referenced Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should always use the workaround to dereference symlinks manually. Keeping an up to date list of all the affected Node versions would become very tedious as it seems that this issue will be present in upcoming Node versions aswell.
(We could also skip copying the
.binfolder entirely as its mostly used for CLI anyways. In a serverless function that doesn't make sense TBH)Closes #1066
Upstream issue in Node: nodejs/node#59168