Skip to content

Fix codecov uploads#139

Merged
jthompson-arcus merged 4 commits intodevfrom
ls_update_codecov
Nov 21, 2024
Merged

Fix codecov uploads#139
jthompson-arcus merged 4 commits intodevfrom
ls_update_codecov

Conversation

@LDSamson
Copy link
Copy Markdown
Collaborator

@LDSamson LDSamson commented Nov 19, 2024

Fixes codecov uploads. Updates the workflow to the latest available one.

@LDSamson LDSamson changed the base branch from main to dev November 19, 2024 10:52
@LDSamson LDSamson changed the title Ls update codecov Fix codecov uploads Nov 21, 2024
@LDSamson LDSamson marked this pull request as ready for review November 21, 2024 15:10
@LDSamson
Copy link
Copy Markdown
Collaborator Author

@jthompson-arcus note that the old workflow might even work now, because James uploaded an organization-wide CODECOV_TOKEN. But this is according to the latest example workflow, probably more future proof, using https://github.com/r-lib/actions/blob/v2-branch/examples/test-coverage.yaml but with codecov-action V5: https://github.com/marketplace/actions/codecov#v5-release

Copy link
Copy Markdown
Collaborator

@jthompson-arcus jthompson-arcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@jthompson-arcus jthompson-arcus merged commit b2bd9bb into dev Nov 21, 2024
@jthompson-arcus jthompson-arcus deleted the ls_update_codecov branch November 21, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants