-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve event labels #151
base: dev
Are you sure you want to change the base?
Improve event labels #151
Conversation
…hat input is verified
…s format. (V0-Vx labels, with a min number of events, that can be become larger if needed)
4527e13
to
2988859
Compare
2988859
to
5315685
Compare
78191a0
to
fda87ad
Compare
@LDSamson I will give it a look. First impressions is that this PR actually reduces flexibility for us. We built the events tab off of the visits, so instead of using V0-Vx (or Visit 1 - Visit X), we were using C1D1-CXDY and there applicable names. This is also why we wanted the additional flexibility during
|
I was not aware that you customized the events tab. This was previously only used for the compact timeline. On a side note, are you using the event_number for something specific? I don't think that was used in clinsight. 'Hard coding' was done for the small timeline but this can be changed. I think the rest is much more flexible in this way, also the normal 'Visit ...' notation is now completely customizable. You can create the same labels as you have now by filling in the table like this, if these patterns match the But you can still provide your own One advantage of this PR is that there can be many more visits, for example during follow-up. The number of visits do not not necessarily have to be hard coded in advance. And it provides a way to deal with unscheduled visits. |
Marking as draft until custom visit labels can be used in the compact timeline again |
Okay, I made improvements and restored the option to customize the compact timeline labels. @aclark02-arcus @jthompson-arcus can you have a look if it works for you? The events tab in the metadata now looks like this: Green columns are optional. From the orange ones, they can be used both but at least one needs to be available. Few more details;
We need this construction mostly because we have studies with an indeterminate number of 'normal' visits and thus need some flexibility in creating event labels. |
Closes #67. This PR adds a lot of flexibility in creating event/visit labels.
The event tab in the metadata now looks like this:
The new setup enables the user to set the logic on which the event labels are created, and to set the names (based on prefix and suffix).
In addition, if a variable with the name 'event_name_edc' is available in the data, and no suffix is set in the table, the event_name_edc will be added to the visit names:
in the timeline:
Lastly, the labels in the compact timeline top right are now the number of 'expected events' but this expand flexibly if more visits occur.
The only thin less flexible are the labels for this compact timeline; these are now always V0-Vx. I don't know how you guys think of this.
The metadata needs to be updated to be able to benefit from this update.