Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

739: add h_simulations_output_format #765

Merged
merged 17 commits into from
Dec 14, 2023

Conversation

ClaraBeckBayer
Copy link
Collaborator

Pull Request

Part of #671

Fixes sub issue #739

Copy link
Contributor

github-actions bot commented Dec 5, 2023

badge

Code Coverage Summary

Filename                    Stmts    Miss  Cover    Missing
------------------------  -------  ------  -------  ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
R/checkmate.R                  73       1  98.63%   72
R/crmPack-package.R             4       0  100.00%
R/CrmPackClass-methods.R        5       0  100.00%
R/Data-class.R                147       5  96.60%   43, 564-565, 571-576
R/Data-methods.R              203       0  100.00%
R/Data-validity.R             144       1  99.31%   21
R/Design-class.R              321       0  100.00%
R/Design-methods.R           2812     784  72.12%   149-153, 169-176, 636-640, 664-667, 675-694, 699-728, 732-733, 735, 750-758, 762, 774-793, 1195-1199, 1326, 1340-1344, 1406, 1596, 1813, 1840-1843, 1852-1863, 1867-1886, 1897-1901, 1907-1919, 2182, 2207-2210, 2217-2228, 2232-2251, 2263-2267, 2273-2285, 2569-2572, 2600-2603, 2611-2623, 2626-2637, 2641-2677, 2694-2703, 2709-2724, 2749, 2790-2791, 3054-3524, 3619-3630, 3633-3644, 3648-3684, 3701-3710, 3718-3733, 3771, 3813-3814, 4093, 4095-4096, 4155, 4191, 4228-4231, 4250-4254, 4315-4322, 4350-4354, 4362-4380, 4406-4425, 4428, 4461, 4483-4501, 4737, 4832
R/Design-validity.R            28       0  100.00%
R/fromQuantiles.R             176      67  61.93%   238-378
R/helpers_broom.R              74      10  86.49%   30, 34-35, 37-38, 40, 81, 102-104
R/helpers_covr.R               23       0  100.00%
R/helpers_data.R               96       1  98.96%   139
R/helpers_design.R            105      35  66.67%   77-129
R/helpers_jags.R               77       0  100.00%
R/helpers_model.R              85       4  95.29%   38, 89-90, 139
R/helpers_rules.R             428       0  100.00%
R/helpers_samples.R             5       0  100.00%
R/helpers_simulations.R        27       0  100.00%
R/helpers.R                   214      61  71.50%   107-127, 162-178, 200-304, 339-353
R/logger.R                     11       0  100.00%
R/mcmc.R                      290      18  93.79%   92-97, 376-377, 387, 389-390, 393-396, 579-580, 669, 675, 733
R/McmcOptions-class.R          22       0  100.00%
R/McmcOptions-methods.R         8       1  87.50%   43
R/McmcOptions-validity.R       42       0  100.00%
R/Model-class.R              1062     166  84.37%   145-147, 216-218, 222-224, 283-285, 357-359, 363-365, 444-446, 513-515, 577-581, 584-587, 690-693, 697-698, 813-817, 937-939, 943-951, 1096-1098, 1103-1106, 1110-1113, 1229-1233, 1235-1238, 1242-1245, 1248, 1409-1419, 1424-1430, 1585-1588, 1594-1601, 1758, 1767, 1776, 1785, 1794-1799, 1935, 1944, 1953, 1961-1963, 2807-2836, 2840-2846, 2853-2857, 2862, 2969-2982, 3008, 3104-3106, 3110, 3203-3205, 3209, 3278-3290, 3308, 3368-3370, 3372-3373, 3376-3381
R/Model-methods.R             472      38  91.95%   78, 233-238, 809-854, 1175-1184
R/Model-validity.R            443      16  96.39%   430-433, 442-445, 596-604
R/ModelParams-class.R          17       0  100.00%
R/ModelParams-validity.R       21       0  100.00%
R/Rules-class.R               458       0  100.00%
R/Rules-methods.R            1536     184  88.02%   889, 892, 895, 1010, 1013, 1016, 1136-1139, 1173, 1276-1279, 1314, 2582-2590, 2614-2621, 2784-2793, 3073-3082, 3215-3458, 3727, 3731, 3776, 3780
R/Rules-validity.R            448      30  93.30%   684-723
R/Samples-class.R               6       0  100.00%
R/Samples-methods.R          1188      21  98.23%   410-420, 648, 1665-1666, 1698, 1711, 1893, 2223-2228
R/Samples-validity.R           10       0  100.00%
R/Simulations-class.R         200       5  97.50%   776-779, 1035
R/Simulations-methods.R      1617    1473  8.91%    65-350, 406, 416-435, 448-453, 500-509, 675-2970
R/Simulations-validity.R       75      75  0.00%    20-168
R/utils.R                       6       0  100.00%
TOTAL                       12979    2996  76.92%

Diff against main

Filename                   Stmts    Miss  Cover
-----------------------  -------  ------  --------
R/Design-methods.R           +25      +5  +0.07%
R/helpers_design.R           +23       0  +9.35%
R/helpers_simulations.R       +9       0  +100.00%
R/helpers.R                  -10       0  -1.27%
R/Simulations-class.R         +1       0  +0.01%
R/Simulations-methods.R      +13     +13  -0.07%
TOTAL                        +61     +18  -0.03%

Results for commit: 518057d

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Dec 5, 2023

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
CrmPackClass-class 💔 $24.41$ $+1.02$ $0$ $0$ $0$ $0$
CrmPackClass-methods 💔 $30.60$ $+25.52$ $+96$ $0$ $0$ $0$
Rules-methods 💚 $50.47$ $-1.61$ $0$ $-1$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
CrmPackClass-class 💔 $24.27$ $+1.02$ CrmPackClass_correctly_identifies_crmPack_classes
CrmPackClass-methods 💚 $30.60$ $-6.46$ tidy_methods_exist_for_all_relevant_classes
CrmPackClass-methods 👶 $+31.98$ tidy_methods_return_non_empty_value_for_all_classes
helpers-simulations 👶 $+0.01$ aggregation_of_additional_stats_works_correctly
helpers_design 👶 $+0.02$ h_simulations_output_format_returns_object_as_expected

Results for commit ef44e88

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 5, 2023

Unit Tests Summary

       1 files       39 suites   3m 45s ⏱️
1 263 tests 1 109 ✔️ 154 💤 0
6 814 runs  6 622 ✔️ 192 💤 0

Results for commit 518057d.

♻️ This comment has been updated with latest results.

@danielinteractive danielinteractive changed the title 739 design h simulations output format 739: add h_simulations_output_format Dec 5, 2023
Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ClaraBeckBayer and @robertadamsbayer , looks good, can then remove commented code

R/helpers_design.R Outdated Show resolved Hide resolved
tests/testthat/test-helpers_design.R Outdated Show resolved Hide resolved
@ClaraBeckBayer ClaraBeckBayer merged commit 902f20d into main Dec 14, 2023
18 checks passed
@ClaraBeckBayer ClaraBeckBayer deleted the 739_design_h_simulations_output_format branch December 14, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants