Implement IncrementsMaxToxProb by Puzzled-Face · Pull Request #861 · openpharma/crmPack

Puzzled-Face · 2024-09-20T13:36:26Z

Pull Request

Fixes #nnn

…bability-of-toxicity' of github.com:openpharma/crmPack into 860-create-an-increments-rule-based-on-limiting-the-probability-of-toxicity

github-actions · 2024-09-20T14:25:56Z

Unit Tests Summary

1 files 45 suites 2m 18s ⏱️
1 350 tests 1 193 ✅ 157 💤 0 ❌
6 578 runs 6 383 ✅ 195 💤 0 ❌

Results for commit 9e3f83e.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-20T14:26:01Z

Unit Test Performance Difference

Test Suite	$Status$	Time on `main`	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
Design-methods	💚	$40.70$	$-3.02$	$0$	$0$	$0$	$0$
Rules-methods	💚	$33.50$	$-4.23$	$+4$	$0$	$0$	$0$
helpers_knitr	💚	$7.92$	$-1.26$	$0$	$0$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on `main`	$±Time$	Test Case
Rules-methods	👶		$+0.27$	maxDose_IncrementsMaxToxProb_works_correctly_with_binary_data
Rules-methods	👶		$+0.27$	maxDose_IncrementsMaxToxProb_works_correctly_with_ordinal_data
Rules-methods	💚	$6.66$	$-1.21$	stopTrial_works_correctly_for_StoppingTDCIRatio_when_samples_are_not_provided
Rules-validity	👶		$+0.04$	v_increments_maxtoxprob_validates_correctly
Rules-validity	👶		$+0.03$	v_nextbest_ordinal_validates_correctly

Results for commit 8600429

♻️ This comment has been updated with latest results.

…bability-of-toxicity' of github.com:openpharma/crmPack into 860-create-an-increments-rule-based-on-limiting-the-probability-of-toxicity

github-actions · 2024-09-23T10:45:04Z

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
R/checkmate.R                        87       2  97.70%   72, 432
R/crmPack-package.R                   4       0  100.00%
R/CrmPackClass-methods.R              5       0  100.00%
R/Data-class.R                      156       5  96.79%   43, 565-566, 572-577
R/Data-methods.R                    267       0  100.00%
R/Data-validity.R                   144       1  99.31%   21
R/Design-class.R                    396       0  100.00%
R/Design-methods.R                 2766    1036  62.55%   563-567, 591-594, 602-621, 626-655, 659-660, 662, 677-685, 689, 701-720, 1122-1126, 1253, 1267-1271, 1333, 1523, 1740, 1767-1770, 1779-1790, 1794-1813, 1824-1828, 1834-1846, 2109, 2134-2137, 2144-2155, 2159-2178, 2190-2194, 2200-2212, 2496-2499, 2527-2530, 2538-2550, 2553-2564, 2568-2604, 2621-2630, 2636-2651, 2676, 2717-2718, 2981-3451, 3546-3557, 3560-3571, 3575-3611, 3628-3637, 3645-3660, 3698, 3740-3741, 3989-4545, 4686, 4774
R/Design-validity.R                  34      10  70.59%   47-56
R/fromQuantiles.R                   172      52  69.77%   294-362
R/helpers_broom.R                    74      10  86.49%   30, 34-35, 37-38, 40, 81, 102-104
R/helpers_covr.R                     23       0  100.00%
R/helpers_data.R                     96       1  98.96%   139
R/helpers_design.R                  126      42  66.67%   22, 77-129, 250, 255-259
R/helpers_jags.R                     77       0  100.00%
R/helpers_knitr_CohortSize.R        109       0  100.00%
R/helpers_knitr_Design.R            346       8  97.69%   24-29, 323-324
R/helpers_knitr_GeneralData.R       190      59  68.95%   75-78, 91-94, 107-110, 122-125, 138-141, 163-165, 248-252, 261-306, 354
R/helpers_knitr_GeneralModel.R      730       3  99.59%   105, 401, 813
R/helpers_knitr_Increments.R        165       1  99.39%   305
R/helpers_knitr_NextBest.R          312       0  100.00%
R/helpers_knitr_SafetyWindow.R      142       1  99.30%   103
R/helpers_knitr_Stopping.R          264       0  100.00%
R/helpers_knitr.R                    12       0  100.00%
R/helpers_model.R                    85       4  95.29%   38, 89-90, 139
R/helpers_rules.R                   428       0  100.00%
R/helpers_samples.R                   5       0  100.00%
R/helpers_simulations.R              27       0  100.00%
R/helpers.R                         214      61  71.50%   107-127, 162-178, 200-302, 337-351
R/logger.R                           11       0  100.00%
R/mcmc.R                            290      18  93.79%   92-97, 376-377, 387, 389-390, 393-396, 579-580, 669, 675, 733
R/McmcOptions-class.R                22       0  100.00%
R/McmcOptions-methods.R               8       1  87.50%   43
R/McmcOptions-validity.R             42       0  100.00%
R/Model-class.R                    1062     166  84.37%   145-147, 216-218, 222-224, 283-285, 357-359, 363-365, 444-446, 513-515, 577-581, 584-587, 690-693, 697-698, 813-817, 937-939, 943-951, 1096-1098, 1103-1106, 1110-1113, 1229-1233, 1235-1238, 1242-1245, 1248, 1409-1419, 1424-1430, 1585-1588, 1594-1601, 1758, 1767, 1776, 1785, 1794-1799, 1935, 1944, 1953, 1961-1963, 2807-2836, 2840-2846, 2853-2857, 2862, 2969-2982, 3008, 3104-3106, 3110, 3203-3205, 3209, 3278-3290, 3308, 3368-3370, 3372-3373, 3376-3381
R/Model-methods.R                   505      38  92.48%   78, 233-238, 809-854, 1175-1184
R/Model-validity.R                  443      16  96.39%   430-433, 442-445, 596-604
R/ModelParams-class.R                17       0  100.00%
R/ModelParams-validity.R             21       0  100.00%
R/Rules-class.R                     467       0  100.00%
R/Rules-methods.R                  1590     183  88.49%   889, 892, 895, 1010, 1013, 1016, 1136-1139, 1173, 1276-1279, 1314, 1804, 2668-2676, 2700-2707, 2870-2879, 3195-3204, 3337-3580, 3867, 3871
R/Rules-validity.R                  454      36  92.07%   335-340, 694-733
R/Samples-class.R                     6       0  100.00%
R/Samples-methods.R                1188      21  98.23%   410-420, 648, 1665-1666, 1698, 1711, 1893, 2223-2228
R/Samples-validity.R                 10       0  100.00%
R/Simulations-class.R               208     103  50.48%   171-182, 419-493, 744-747, 943-976, 1004
R/Simulations-methods.R            1617    1473  8.91%    65-350, 406, 416-435, 448-453, 500-509, 674-2969
R/Simulations-validity.R             75      75  0.00%    20-168
R/utils.R                             6       0  100.00%
TOTAL                             15498    3426  77.89%

Diff against main

Filename              Stmts    Miss  Cover
------------------  -------  ------  --------
R/Rules-class.R          +4       0  +100.00%
R/Rules-methods.R       +29      +1  +0.15%
R/Rules-validity.R       +6      +6  -1.23%
TOTAL                   +39      +7  +0.01%

Results for commit: 9e3f83e

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

danielinteractive

looks pretty good already, thanks @Puzzled-Face

Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com>

…bability-of-toxicity' of github.com:openpharma/crmPack into 860-create-an-increments-rule-based-on-limiting-the-probability-of-toxicity

…ing-the-probability-of-toxicity

…bability-of-toxicity' of github.com:openpharma/crmPack into 860-create-an-increments-rule-based-on-limiting-the-probability-of-toxicity

Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com>

…ing-the-probability-of-toxicity

Implement IncrementsMaxToxProb

60e416b

Puzzled-Face requested a review from danielinteractive as a code owner September 20, 2024 13:36

Puzzled-Face linked an issue Sep 20, 2024 that may be closed by this pull request

Create an Increments rule based on limiting the probability of toxicity #860

Closed

github-actions Bot and others added 4 commits September 20, 2024 13:39

[skip style] [skip vbump] Restyle files

3db5599

Fix lintr errors

4d3a179

Merge branch '860-create-an-increments-rule-based-on-limiting-the-pro…

2df024e

…bability-of-toxicity' of github.com:openpharma/crmPack into 860-create-an-increments-rule-based-on-limiting-the-probability-of-toxicity

[skip style] [skip vbump] Restyle files

15fa563

Puzzled-Face added 2 commits September 23, 2024 10:24

Use seq-alone correctly

b51b8c5

Merge branch '860-create-an-increments-rule-based-on-limiting-the-pro…

8fd5879

…bability-of-toxicity' of github.com:openpharma/crmPack into 860-create-an-increments-rule-based-on-limiting-the-probability-of-toxicity

Fix documentation

c4477bd

danielinteractive reviewed Sep 23, 2024

View reviewed changes

Comment thread R/Rules-methods.R Outdated

Comment thread R/Rules-methods.R Outdated

Comment thread R/Rules-methods.R Outdated

Comment thread R/Rules-validity.R Outdated

Comment thread R/Rules-validity.R

Comment thread examples/Rules-method-maxDose-IncrementsMaxToxProb.R

Puzzled-Face and others added 10 commits September 23, 2024 14:58

Update R/Rules-validity.R

6a996c6

Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com>

Update R/Rules-methods.R

b1789e1

Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com>

Update R/Rules-methods.R

cee9342

Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com>

Refactor as per reviewer request. Additional unit tests.

2afe296

[skip style] [skip vbump] Restyle files

f453f9a

Respond to reviewer comments. Fix pkgdown errors.

c1bf1bf

Merge branch '860-create-an-increments-rule-based-on-limiting-the-pro…

c13af55

…bability-of-toxicity' of github.com:openpharma/crmPack into 860-create-an-increments-rule-based-on-limiting-the-probability-of-toxicity

Fix documentation error

de9a932

Merge branch 'main' into 860-create-an-increments-rule-based-on-limit…

82030cc

…ing-the-probability-of-toxicity

Merge branch 'main' into 860-create-an-increments-rule-based-on-limit…

3aa8100

…ing-the-probability-of-toxicity

Puzzled-Face requested a review from danielinteractive September 30, 2024 09:48

Puzzled-Face and others added 3 commits September 30, 2024 09:51

Fix R CMD Check warning

d52edc2

Merge branch '860-create-an-increments-rule-based-on-limiting-the-pro…

f4c8e03

…bability-of-toxicity' of github.com:openpharma/crmPack into 860-create-an-increments-rule-based-on-limiting-the-probability-of-toxicity

[skip style] [skip vbump] Restyle files

417c9a5

danielinteractive approved these changes Oct 7, 2024

View reviewed changes

Comment thread R/Rules-methods.R Outdated

Update R/Rules-methods.R

31cfb0b

Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com>

Merge branch 'main' into 860-create-an-increments-rule-based-on-limit…

9e3f83e

…ing-the-probability-of-toxicity

Puzzled-Face merged commit 4d3d3d4 into main Oct 7, 2024

Puzzled-Face deleted the 860-create-an-increments-rule-based-on-limiting-the-probability-of-toxicity branch October 7, 2024 09:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement IncrementsMaxToxProb#861

Implement IncrementsMaxToxProb#861
Puzzled-Face merged 23 commits intomainfrom
860-create-an-increments-rule-based-on-limiting-the-probability-of-toxicity

Puzzled-Face commented Sep 20, 2024

Uh oh!

github-actions Bot commented Sep 20, 2024 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 20, 2024 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 23, 2024 •

edited

Loading

Uh oh!

danielinteractive left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Puzzled-Face commented Sep 20, 2024

Pull Request

Uh oh!

github-actions Bot commented Sep 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Tests Summary

Uh oh!

github-actions Bot commented Sep 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Performance Difference

Uh oh!

github-actions Bot commented Sep 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Diff against main

Uh oh!

danielinteractive left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Sep 20, 2024 •

edited

Loading

github-actions Bot commented Sep 20, 2024 •

edited

Loading

github-actions Bot commented Sep 23, 2024 •

edited

Loading