Optionally panic on failed reconstruct #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 16, 2024 16:17
Switch from passing a bunch of loose variables to a ConsumerConfig object. This will make future configuration updates less invasive.
| @@ -9,6 +9,7 @@ import ( | |||
| // "strings" | |||
| "regexp" | |||
| "runtime" | |||
| // "fmt" | |||
There was a problem hiding this comment.
Not really. I find myself enabling and disabling fmt often while debugging, so I left it in commented to make it slightly easier to access next time I'm using it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reconstructs fail, updates will likely be missing. For some applications this can be okay, but for many it would be better to panic in this scenario, so whether a panic occurs is made configurable.