peermanager plugin #18
Conversation
plugins/peermanager/main.go
Outdated
| ) | ||
|
|
||
| type peerManagerConfig struct { | ||
| BrokerURL string `yaml:"peerManager.broker.url"` |
There was a problem hiding this comment.
Let's make the yaml broker.url. Since plugeth2 will have its own config files for each plugin, we don't need to namespace it here too.
plugins/peermanager/main.go
Outdated
| log.Error("error calling getEnode from sessionService, peer manager plugin", "err", err) | ||
| } | ||
|
|
||
| chainTopic, err := sessionPeerService.chainIdResolver() |
There was a problem hiding this comment.
Let's pull the topic from the config. We can use chainIdResolver() if it's not explicitly set, but making this configurable would let us have separate clusters of nodes we don't force to peer with eachother.
plugins/peermanager/peer-manager.go
Outdated
| } | ||
|
|
||
| type pseudoNodeInfo struct { | ||
| Enode string |
There was a problem hiding this comment.
Let's add JSON hints here. I don't like relying on struct field names for JSON encoding / decoding when we can be explicit.
plugins/peermanager/peer-manager.go
Outdated
| result = "sepolia" | ||
| case "0x89": | ||
| result = "polygon" | ||
| case "0x13881": |
There was a problem hiding this comment.
Let's add amoy here too:
"0x13882"
plugins/peermanager/manager.go
Outdated
| default: | ||
| log.Warn("unknown chain, chainID could not be resolved, peer manager plugin") | ||
| result = chainID | ||
| result = "unknownChain" |
There was a problem hiding this comment.
We need this to at least reflect the chainid, otherwise if we're running multiple different unsupported chains they'll publish to the same topic and try to peer with eachother.
Let's set this to
result = fmt.Sprintf("%x", id)
No description provided.