When building from RPM auto/feature lacks LD_LIBRARY_PATH to be able to run the test. #1581
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, the issue is when building as part of an RPM the luajit SO is in temp location and is not rpath'ed but the the temp location is not in ld config so test doesn't run as it can't find luajit SO.
This is a hack to demo how to remediate it for RPM build, but it's obviously insufficient for all possible build paths and should probably not applied as is.
I hereby granted the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.