Building as dynamic module support#9
Closed
cryptofuture wants to merge 3 commits intoopenresty:masterfrom
cryptofuture:master
Closed
Building as dynamic module support#9cryptofuture wants to merge 3 commits intoopenresty:masterfrom cryptofuture:master
cryptofuture wants to merge 3 commits intoopenresty:masterfrom
cryptofuture:master
Conversation
Member
|
@cryptofuture Please review the patch from pull request #4 since that pull request requires its own review and modification process. In general, pull requests should be minimal and self-contained. |
Author
|
I added it after this pull request in fork I use for nginx ppa I maintain. Sorry, I didn't thought about applying request 4 in new branch. Basically you can apply request #4 first (since nothing bad with it), then apply #9 , or merge it separately. Otherwise I can just close this one, refork things and recreate pure pull request (will do it if you don't reply next hour) |
This reverts commit 04c3f25.
Member
|
@cryptofuture #4 cannot be merged as-is. It requires coding style fixes at least. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ability to build module as dynamic nginx module. (converted to dynamic)
Description here.