Skip to content

Conversation

@timtebeek
Copy link
Member

What's changed?

Add type mapping from Kotlin primitive types to their Java counterparts, and use those in the type system.

What's your motivation?

As described in openrewrite/rewrite-kotlin#626 we had up to now mapped any primitive as a Kotlin primitive, even when those classes come from Java. That's problematic when say a method matcher for a Java method has a primitive type declared for the matcher. Those would then fail to match when used from Kotlin. While that's perhaps not very common, it's nonetheless important as we look to cover both with a single set of recipes, and for new recipes developed.

Anything in particular you'd like reviewers to focus on?

Should we continue to use Kotlin primitives types when methods are defined in Kotlin? How do we tell those apart? Can we make that work on 1.9? Would it help to move to 2.0 or 2.1?

Any additional context

@timtebeek
Copy link
Member Author

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2025

This PR is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in two weeks. PRs may be reopened when there is renewed interest.

@github-actions github-actions bot added the Stale label Aug 4, 2025
@timtebeek timtebeek added parser enhancement New feature or request question Further information is requested labels Aug 4, 2025
@github-actions github-actions bot removed the Stale label Aug 11, 2025
@github-actions
Copy link
Contributor

This PR is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in two weeks. PRs may be reopened when there is renewed interest.

@github-actions github-actions bot added the Stale label Nov 10, 2025
@github-actions github-actions bot closed this Nov 24, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in OpenRewrite Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request kotlin parser question Further information is requested Stale

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants