Fixed situation where a changing a managed dependency that does not have an explicit version
tag would fail to add a version
tag when providing the newVersion
option.
#6105
+148
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
version
tag (because the version was applied to the managed dependency in an external parent artifact), callingChangeManagedDependencyGroupIdAndArtifactId
would fail to make the full needed change. Now it will add theversion
tag to the managed dependency.What's your motivation?
This was preventing managed dependencies from being updated correctly.
Still TODO
A
) w/o aversion
tag, and a direct dependency in a child module (let's call it projectB
)'s POM also w/o aversion
tag. In this situation, what appears to be happening right now is that the POM for projectA
is getting the version number added correctly to the managed dependency, but at the same time, the POM for projectB
is getting a version number added incorrectly to the direct dependency.RemoveRedundantDependencyVersions
in theory should have been able to handle this, but I believe it to not be detecting the change that occurred in projectA
's POM due to not having re-evaluated theMavenResolutionResult
again after the change.Checklist