Skip to content

JavaScript - fix whitespace attachment for for-loops with newlines after parens #6252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
+7 −2
Draft

JavaScript - fix whitespace attachment for for-loops with newlines after parens #6252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c0b6eb
Fix whitespace attachment for for-loops with newlines after parens
greg-at-moderne Nov 4, 2025
d1cebad
Merge remote-tracking branch 'origin/main' into greg-js-whitespace-fi…
greg-at-moderne Nov 5, 2025
7087398
Merge remote-tracking branch 'origin/main' into greg-js-whitespace-fi…
greg-at-moderne Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rewrite-javascript/rewrite/src/javascript/parser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3079,7 +3079,7 @@ export class JavaScriptParserVisitor {
return this.rightPadded({
kind: J.Kind.VariableDeclarations,
id: randomId(),
prefix: isMulti ? this.prefix(declaration) : emptySpace,
prefix: this.prefix(declaration),
markers: emptyMarkers,
leadingAnnotations: [],
modifiers: isMulti ? [] : modifiers,
Expand Down
7 changes: 6 additions & 1 deletion rewrite-javascript/rewrite/test/javascript/whitespace-attachment.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,12 @@ describe('whitespace should be attached to the outermost element', () => {
"const userScores = new Map<string, number>()",
"function* generateUsers() { yield { id: 1 } };",
"type T = undefined extends undefined ? string : never;",
"const FirstEntity = class FirstEntityClass {};"
"const FirstEntity = class FirstEntityClass {};",
`
for (
let i = 0; i < numberOfConnections; i++
) {}
`
])('%s', async (sourceCode) => {
// given
const parser = new JavaScriptParser();
Expand Down
Loading