Skip to content

Conversation

@gliptak
Copy link

@gliptak gliptak commented Nov 8, 2025

What's changed?

Fix StackoverflowError in Kotlin type processing

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

Copilot AI and others added 2 commits November 8, 2025 14:16
gliptak and others added 2 commits November 8, 2025 20:09
…tilsTest.java

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@timtebeek
Copy link
Member

Thanks for the suggested fix here @gliptak ! Let me check with @knutwannheden if there's any alternatives, as we're quite sensitive to performance changes in this part, and the new set allocation and additions might cause a bit of a regression that can perhaps be tackled elsewhere, such as in the parser that creates the type information.

@timtebeek timtebeek added bug Something isn't working performance kotlin labels Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working kotlin performance

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

StackOverflowError on org.openrewrite.java.ReplaceConstantWithAnotherConstant

2 participants