feat(egress): support multiple user mitm addon scripts#1126
Merged
Conversation
…rated env OPENSANDBOX_EGRESS_MITMPROXY_SCRIPT now accepts comma-separated paths (e.g. "/a.py,/b.py"), each passed as a separate `-s` flag to mitmdump after the system addon. Single-path usage remains unchanged. - Config.ScriptPath string → ScriptPaths []string - Extract buildMitmdumpArgs() for testability - Add parseScriptPaths() for comma-separated env parsing - Add 4 unit tests covering single, multiple, and empty/whitespace cases - Update docs and comments Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e675ef2536
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OPENSANDBOX_EGRESS_MITMPROXY_SCRIPTnow accepts comma-separated paths (e.g./a.py,/b.py), each passed as a separate-sflag to mitmdump after the system addonConfig.ScriptPath string→ScriptPaths []string，extractbuildMitmdumpArgs()for testabilityparseScriptPaths()for comma-separated env parsing, 4 unit tests covering single/multiple/empty casesTest plan
go test ./components/egress/pkg/mitmproxy/...🤖 Generated with Claude Code